Messages in this thread | | | Date | Tue, 22 Apr 2014 01:23:52 +0800 | Subject | Re: [PATCH 16/28] nios2: System calls handling | From | Ley Foon Tan <> |
| |
On Sun, Apr 20, 2014 at 4:12 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: >> + */ >> + vma = find_vma(current->mm, addr); >> + if (vma == NULL || addr < vma->vm_start || addr + len > vma->vm_end) >> + return -EFAULT; >> + >> + /* Ignore the scope and cache arguments. */ > > This function doesn't have scope and cache arguments > (sys_cacheflush() on m68k does have them ;-)
Missed out the comment after rename the arguments.:) Will update the comment above.
> On Sat, Apr 19, 2014 at 6:09 PM, Pavel Machek <pavel@denx.de> wrote: >> Also... explanation why you need this syscall while other >> architectures live happily without it would be nice. > > 12 our of 28 architectures provide such a syscall... > > Is flushing the cache a privileged operation on nios2? Yes.
Thanks.
Regards Ley Foon
| |