lkml.org 
[lkml]   [1998]   [Apr]   [26]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSun, 26 Apr 1998 17:12:33 +0200
FromPavel Machek <>
SubjectRe: patch parport/bitops
Hi!

> Any objections/comments?

It's rather long and code repeats...

> diff -u -r -N linux-2.1.97-orig/include/asm-alpha/bitops.h linux/include/asm-alpha/bitops.h
> --- linux-2.1.97-orig/include/asm-alpha/bitops.h	Mon Mar 30 10:21:40 1998
> +++ linux/include/asm-alpha/bitops.h	Wed Apr 22 09:29:09 1998
> @@ -183,6 +183,70 @@

Code in asm-alpha/bitops.h, asm-arm, asm-generic, parts of
asm-i386/bitops.h, etc. seems exactly same to me. Copying is not good
programming technology. Maybe you should create functions like
generic_ffs() in linux/bitops.h, and #define ffs generic_ffs in
arch-specific pieces?

								Pavel

-- 
I'm really pavel@atrey.karlin.mff.cuni.cz. 	   Pavel
Look at http://atrey.karlin.mff.cuni.cz/~pavel/ ;-).

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu

\
 
 \ /
  Last update: 2005-03-22 13:42    [from the cache]
©2003-2008