| Date | Thu, 1 Aug 2019 18:11:44 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v6 55/57] platform/x86: intel_int0002_vgpio: Remove dev_err() usage after platform_get_irq() |
| |
On Tue, Jul 30, 2019 at 11:15:55AM -0700, Stephen Boyd wrote: > We don't need dev_err() messages when platform_get_irq() fails now that > platform_get_irq() prints an error message itself when something goes > wrong. Let's remove these prints with a simple semantic patch. > > // <smpl> > @@ > expression ret; > struct platform_device *E; > @@ > > ret = > ( > platform_get_irq(E, ...) > | > platform_get_irq_byname(E, ...) > ); > > if ( \( ret < 0 \| ret <= 0 \) ) > { > ( > -if (ret != -EPROBE_DEFER) > -{ ... > -dev_err(...); > -... } > | > ... > -dev_err(...); > ) > ... > } > // </smpl> > > While we're here, remove braces on if statements that only have one > statement (manually).
All 4 pushed to my review and testing queue, thanks!
P.S. Please, consider Cc'ing PDx86 mailing list next time for contribution. Otherwise it misses our patchwork.
> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com> > Cc: Hans de Goede <hdegoede@redhat.com> > Cc: "Darren Hart (VMware)" <dvhart@infradead.org> > Cc: Roman Kiryanov <rkir@google.com> > Cc: Vadim Pasternak <vadimp@mellanox.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > > Please apply directly to subsystem trees > > drivers/platform/x86/intel_int0002_vgpio.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/platform/x86/intel_int0002_vgpio.c b/drivers/platform/x86/intel_int0002_vgpio.c > index d9542c661ddc..4f3f30152a27 100644 > --- a/drivers/platform/x86/intel_int0002_vgpio.c > +++ b/drivers/platform/x86/intel_int0002_vgpio.c > @@ -166,10 +166,8 @@ static int int0002_probe(struct platform_device *pdev) > return -ENODEV; > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(dev, "Error getting IRQ: %d\n", irq); > + if (irq < 0) > return irq; > - } > > chip = devm_kzalloc(dev, sizeof(*chip), GFP_KERNEL); > if (!chip) > -- > Sent by a computer through tubes >
-- With Best Regards, Andy Shevchenko
|