lkml.org 
[lkml]   [2019]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v6 39/57] rtc: Remove dev_err() usage after platform_get_irq()
    Hi Stephen,

    On Tue, Jul 30, 2019 at 8:21 PM Stephen Boyd <swboyd@chromium.org> wrote:
    > We don't need dev_err() messages when platform_get_irq() fails now that
    > platform_get_irq() prints an error message itself when something goes
    > wrong. Let's remove these prints with a simple semantic patch.
    >
    > // <smpl>
    > @@
    > expression ret;
    > struct platform_device *E;
    > @@
    >
    > ret =
    > (
    > platform_get_irq(E, ...)
    > |
    > platform_get_irq_byname(E, ...)
    > );
    >
    > if ( \( ret < 0 \| ret <= 0 \) )
    > {
    > (
    > -if (ret != -EPROBE_DEFER)
    > -{ ...
    > -dev_err(...);
    > -... }
    > |
    > ...
    > -dev_err(...);
    > )
    > ...
    > }
    > // </smpl>
    >
    > While we're here, remove braces on if statements that only have one
    > statement (manually).
    >
    > Cc: Alessandro Zummo <a.zummo@towertech.it>
    > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
    > Cc: linux-rtc@vger.kernel.org
    > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > Signed-off-by: Stephen Boyd <swboyd@chromium.org>
    > ---
    >
    > Please apply directly to subsystem trees
    >
    > drivers/rtc/rtc-88pm80x.c | 1 -
    > drivers/rtc/rtc-88pm860x.c | 4 +---
    > drivers/rtc/rtc-ac100.c | 4 +---
    > drivers/rtc/rtc-armada38x.c | 5 +----
    > drivers/rtc/rtc-asm9260.c | 4 +---
    > drivers/rtc/rtc-at91rm9200.c | 4 +---
    > drivers/rtc/rtc-at91sam9.c | 4 +---
    > drivers/rtc/rtc-bd70528.c | 5 +----
    > drivers/rtc/rtc-davinci.c | 4 +---
    > drivers/rtc/rtc-jz4740.c | 4 +---
    > drivers/rtc/rtc-max77686.c | 5 +----
    > drivers/rtc/rtc-mt7622.c | 1 -
    > drivers/rtc/rtc-pic32.c | 4 +---
    > drivers/rtc/rtc-pm8xxx.c | 4 +---
    > drivers/rtc/rtc-puv3.c | 8 ++------
    > drivers/rtc/rtc-pxa.c | 8 ++------
    > drivers/rtc/rtc-rk808.c | 6 +-----
    > drivers/rtc/rtc-s3c.c | 8 ++------
    > drivers/rtc/rtc-sc27xx.c | 4 +---
    > drivers/rtc/rtc-spear.c | 4 +---
    > drivers/rtc/rtc-stm32.c | 1 -
    > drivers/rtc/rtc-sun6i.c | 4 +---
    > drivers/rtc/rtc-sunxi.c | 4 +---
    > drivers/rtc/rtc-tegra.c | 4 +---
    > drivers/rtc/rtc-vt8500.c | 4 +---
    > drivers/rtc/rtc-xgene.c | 4 +---
    > drivers/rtc/rtc-zynqmp.c | 8 ++------
    > 27 files changed, 28 insertions(+), 92 deletions(-)

    Failed to catch:
    drivers/rtc/rtc-sh.c: ret = platform_get_irq(pdev, 0);
    drivers/rtc/rtc-sh.c- if (unlikely(ret <= 0)) {
    drivers/rtc/rtc-sh.c- dev_err(&pdev->dev, "No IRQ resource\n");
    drivers/rtc/rtc-sh.c- return -ENOENT;
    drivers/rtc/rtc-sh.c- }
    drivers/rtc/rtc-sh.c-

    Note that there are two more calls for optional interrupts:
    drivers/rtc/rtc-sh.c: rtc->carry_irq = platform_get_irq(pdev, 1);
    drivers/rtc/rtc-sh.c: rtc->alarm_irq = platform_get_irq(pdev, 2);

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2019-08-08 10:06    [W:4.061 / U:0.580 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site