lkml.org 
[lkml]   [2019]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v6 18/57] i2c: Remove dev_err() usage after platform_get_irq()
Date
Quoting Wolfram Sang (2019-07-31 07:30:11)
> > -dev_err(...);
>
> What about pr_err, ...?

Sure. I haven't tried to find these ones or pr_warn(), etc.

>
> > While we're here, remove braces on if statements that only have one
> > statement (manually).
>
> You can let cocci do this for you, too. From the top of my head:
>
> if (...)
> - {
> S
> - }
>
> with S being a statement and this rule depending on the matching rule.
>

Cool thanks for the tip! I'll have to try it out.

\
 
 \ /
  Last update: 2019-07-31 16:47    [W:0.215 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site