Messages in this thread | | | From | Stephen Boyd <> | Subject | Re: [PATCH v6 18/57] i2c: Remove dev_err() usage after platform_get_irq() | Date | Wed, 31 Jul 2019 07:46:47 -0700 |
| |
Quoting Wolfram Sang (2019-07-31 07:30:11) > > -dev_err(...); > > What about pr_err, ...?
Sure. I haven't tried to find these ones or pr_warn(), etc.
> > > While we're here, remove braces on if statements that only have one > > statement (manually). > > You can let cocci do this for you, too. From the top of my head: > > if (...) > - { > S > - } > > with S being a statement and this rule depending on the matching rule. >
Cool thanks for the tip! I'll have to try it out.
| |