Messages in this thread | | | Subject | Re: [PATCH v6 23/57] irqchip: Remove dev_err() usage after platform_get_irq() | From | Marc Zyngier <> | Date | Wed, 7 Aug 2019 15:23:09 +0100 |
| |
Hi Stephen,
On 30/07/2019 19:15, Stephen Boyd wrote: > We don't need dev_err() messages when platform_get_irq() fails now that > platform_get_irq() prints an error message itself when something goes > wrong. Let's remove these prints with a simple semantic patch. > > // <smpl> > @@ > expression ret; > struct platform_device *E; > @@ > > ret = > ( > platform_get_irq(E, ...) > | > platform_get_irq_byname(E, ...) > ); > > if ( \( ret < 0 \| ret <= 0 \) ) > { > ( > -if (ret != -EPROBE_DEFER) > -{ ... > -dev_err(...); > -... } > | > ... > -dev_err(...); > ) > ... > } > // </smpl> > > While we're here, remove braces on if statements that only have one > statement (manually). > > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: Marc Zyngier <marc.zyngier@arm.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > > Please apply directly to subsystem trees > > drivers/irqchip/irq-imgpdc.c | 8 ++------ > drivers/irqchip/irq-keystone.c | 4 +--- > drivers/irqchip/qcom-irq-combiner.c | 4 +--- > 3 files changed, 4 insertions(+), 12 deletions(-) > > diff --git a/drivers/irqchip/irq-imgpdc.c b/drivers/irqchip/irq-imgpdc.c > index d00489a4b54f..698d07f48fed 100644 > --- a/drivers/irqchip/irq-imgpdc.c > +++ b/drivers/irqchip/irq-imgpdc.c > @@ -362,10 +362,8 @@ static int pdc_intc_probe(struct platform_device *pdev) > } > for (i = 0; i < priv->nr_perips; ++i) { > irq = platform_get_irq(pdev, 1 + i); > - if (irq < 0) { > - dev_err(&pdev->dev, "cannot find perip IRQ #%u\n", i); > + if (irq < 0)
There's a bug here. irq == 0 *is* an error. Same thing for the next two hunks. Nothing wrong with your patch though.
I guess I'll fix it on top as I apply it.
Thanks,
M. -- Jazz is not dead. It just smells funny...
| |