lkml.org 
[lkml]   [2019]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v6 20/57] infiniband: Remove dev_err() usage after platform_get_irq()
    From
    Date
    On Tue, 2019-07-30 at 11:15 -0700, Stephen Boyd wrote:
    > We don't need dev_err() messages when platform_get_irq() fails now
    > that
    > platform_get_irq() prints an error message itself when something goes
    > wrong. Let's remove these prints with a simple semantic patch.
    >
    > // <smpl>
    > @@
    > expression ret;
    > struct platform_device *E;
    > @@
    >
    > ret =
    > (
    > platform_get_irq(E, ...)
    > platform_get_irq_byname(E, ...)
    > );
    >
    > if ( \( ret < 0 \| ret <= 0 \) )
    > {
    > (
    > -if (ret != -EPROBE_DEFER)
    > -{ ...
    > -dev_err(...);
    > -... }
    > ...
    > -dev_err(...);
    > )
    > ...
    > }
    > // </smpl>
    >
    > While we're here, remove braces on if statements that only have one
    > statement (manually).
    >
    > Cc: Doug Ledford <dledford@redhat.com>
    > Cc: Jason Gunthorpe <jgg@ziepe.ca>
    > Cc: linux-rdma@vger.kernel.org
    > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > Signed-off-by: Stephen Boyd <swboyd@chromium.org>
    > ---
    >
    > Please apply directly to subsystem trees
    >

    Thanks for being clear about where you wanted these applied. This patch
    applied to rdma for-next, thanks.

    --
    Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2019-07-31 17:54    [W:2.620 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site