Messages in this thread | | | Date | Wed, 31 Jul 2019 09:39:12 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH v6 36/57] pwm: Remove dev_err() usage after platform_get_irq() |
| |
On Wed, Jul 31, 2019 at 09:13:01AM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 31, 2019 at 08:58:53AM +0200, Uwe Kleine-König wrote: > > On Tue, Jul 30, 2019 at 11:15:36AM -0700, Stephen Boyd wrote: > > > We don't need dev_err() messages when platform_get_irq() fails now that > > > platform_get_irq() prints an error message itself when something goes > > > wrong. Let's remove these prints with a simple semantic patch. > > > > Looking at v5.3-rc2 it's not obvious to me that all error paths of > > platform_get_irq issue an error message. Do I miss something? > > The commit is in my driver-core tree at the moment, so this should wait > until 5.4-rc1. I woudn't recommend merging it in 5.3-rc as it's not a > bugfix.
As this is a new change pointing out its id in the commit log of the follow up changes might be beneficial.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
| |