| From | Linus Walleij <> | Date | Wed, 16 Oct 2019 15:12:36 +0200 | Subject | Re: [PATCH 23/36] ARM: s3c: move s3cmci pinctrl handling into board files |
| |
On Thu, Oct 10, 2019 at 10:47 PM Arnd Bergmann <arnd@arndb.de> wrote:
> Rather than call the internal s3c_gpio_cfgall_range() function > through a platform header, move the code into the set_power > callback that is already exported by the board, and add > a default implementation. > > In DT mode, the code already does not set the pin config, > so nothing changes there. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
It looks good: Acked-by: Linus Walleij <linus.walleij@linaro.org>
It would feel better if someone was actually testing it on these boards. I see Ben is listed as maintainer so I bet he will pull the board out :)
Yours, Linus Walleij
|