Messages in this thread | | | From | Arnd Bergmann <> | Date | Wed, 23 Oct 2019 15:29:40 +0200 | Subject | Re: [PATCH 21/36] ARM: s3c: move iis pinctrl config into boards |
| |
On Wed, Oct 23, 2019 at 2:51 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > On Thu, Oct 10, 2019 at 10:30:05PM +0200, Arnd Bergmann wrote: > > The s3c_gpio_cfgall_range() function is an internal interface of > > the samsung gpio driver and should not be called directly by drivers, > > so move the iis pin initialization into the boards. > > > > Note that the s3c2412-i2s driver has no boards using it in > > mainline linux, the driver gets selected for the jive machine > > but is never instantiated.
> This is not entirely equivalent move as before this was probe (so being > executed also on rebinds) and now it is init. I guess it should not make > any difference so let it be.
Right, I've added an explanation in the changelog text now:
The s3c_gpio_cfgall_range() function is an internal interface of the samsung gpio driver and should not be called directly by drivers, so move the iis pin initialization into the boards.
+This means the pin configuration is only run once at early boot, rather +than each time the driver binds, but the effect should be the same.
Arnd
| |