Messages in this thread | | | From | Arnd Bergmann <> | Date | Wed, 23 Oct 2019 15:57:51 +0200 | Subject | Re: [PATCH 31/36] ARM: s3c: cpufreq: use global s3c2412_cpufreq_setrefresh |
| |
On Wed, Oct 23, 2019 at 3:44 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > On Thu, Oct 10, 2019 at 10:30:15PM +0200, Arnd Bergmann wrote:
> > @@ -246,6 +246,7 @@ extern int s3c2412_iotiming_calc(struct s3c_cpufreq_config *cfg, > > > > extern void s3c2412_iotiming_set(struct s3c_cpufreq_config *cfg, > > struct s3c_iotimings *iot); > > +extern void s3c2412_cpufreq_setrefresh(struct s3c_cpufreq_config *cfg); > > I think that it does not cover the !CONFIG_S3C2412_IOTIMING case. > Either you need to provide also the empty stub or add default=y to > S3C2412_IOTIMING. Otherwise cpufreq driver might end up without this.
S3C2412_IOTIMING is not currently optional, it always gets selected by ARM_S3C2412_CPUFREQ, unlike S3C2410_IOTIMING which is only selected by specific boards for reasons I don't understand.
Arnd
| |