lkml.org 
[lkml]   [2015]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v5 17/21] clk: tegra: pll: Add logic for SS
From
On Tue, May 12, 2015 at 10:24 AM, Rhyland Klein <rklein@nvidia.com> wrote:
> +static void pll_clk_start_ss(struct tegra_clk_pll *pll)
> +{
> + if (pll->params->defaults_set && pll->params->ssc_ctrl_en_mask) {

Is there any reason you're checking for the existence of
ssc_ctrl_en_mask rather than ssc_ctrl_reg?

> + u32 val = pll_readl(pll->params->ssc_ctrl_reg, pll);
> +
> + val |= pll->params->ssc_ctrl_en_mask;
> + pll_writel(val, pll->params->ssc_ctrl_reg, pll);
> + }
> +}
> +
> +static void pll_clk_stop_ss(struct tegra_clk_pll *pll)
> +{
> + if (pll->params->defaults_set && pll->params->ssc_ctrl_en_mask) {
> + u32 val = pll_readl(pll->params->ssc_ctrl_reg, pll);
> +
> + val &= ~pll->params->ssc_ctrl_en_mask;
> + pll_writel(val, pll->params->ssc_ctrl_reg, pll);
> + }
> +}
> +




--
Benson Leung
Software Engineer, Chrom* OS
bleung@chromium.org


\
 
 \ /
  Last update: 2015-05-14 02:41    [W:0.242 / U:0.752 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site