lkml.org 
[lkml]   [2015]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v5 19/21] clk: tegra: Add Super Gen5 Logic
Date

> -----Original Message-----
> From: bleung@google.com [mailto:bleung@google.com] On Behalf Of Benson
> Leung
> Sent: Friday, May 15, 2015 3:37 AM
> To: Rhyland Klein
> Cc: Peter De Schrijver; Mike Turquette; Stephen Warren; Stephen Boyd; Thierry
> Reding; Alexandre Courbot; Bill Huang; Paul Walmsley; Jim Lin; linux-
> clk@vger.kernel.org; linux-tegra@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v5 19/21] clk: tegra: Add Super Gen5 Logic
>
> On Tue, May 12, 2015 at 10:24 AM, Rhyland Klein <rklein@nvidia.com> wrote:
> > From: Bill Huang <bilhuang@nvidia.com>
> >
> > Super clock divider control and clock source mux of Tegra210 has
> > changed a little against prior SoCs, this patch adds Gen5 logic to
> > address those differences.
> >
> > Signed-off-by: Bill Huang <bilhuang@nvidia.com>
> > ---
> > v2:
> > - Fixed sclk divider address (0x370 -> 0x2c)
> >
> > drivers/clk/tegra/Makefile | 1 +
> > drivers/clk/tegra/clk-tegra-super-gen5.c | 150
> ++++++++++++++++++++++++++++++
> > drivers/clk/tegra/clk.h | 3 +
> > 3 files changed, 154 insertions(+)
> > create mode 100644 drivers/clk/tegra/clk-tegra-super-gen5.c
>
> I've diffed clk-tegra-super-gen5.c and the existing clk-tegra-super-gen4.c, and
> there's a lot of code duplication here.
> They're the same pair of functions, with several small changes. Since the idea
> behind pulling out the super clock initialization into a common file was to reuse
> the same init, could we extend the super-gen4 file (rename if you have to) to
> support both gens instead?
>
Thanks, we'll integrate gen5 into gen4 file in v6.
> --
> Benson Leung
> Software Engineer, Chrom* OS
> bleung@chromium.org
\
 
 \ /
  Last update: 2015-05-25 10:41    [W:0.523 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site