lkml.org 
[lkml]   [2013]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm, numa: Sanitize task_numa_fault() callsites
On Thu, Jul 25, 2013 at 12:38:45PM +0200, Peter Zijlstra wrote:
>
> Subject: mm, numa: Sanitize task_numa_fault() callsites
> From: Peter Zijlstra <peterz@infradead.org>
> Date: Mon Jul 22 10:42:38 CEST 2013
>
> There are three callers of task_numa_fault():
>
> - do_huge_pmd_numa_page():
> Accounts against the current node, not the node where the
> page resides, unless we migrated, in which case it accounts
> against the node we migrated to.
>
> - do_numa_page():
> Accounts against the current node, not the node where the
> page resides, unless we migrated, in which case it accounts
> against the node we migrated to.
>
> - do_pmd_numa_page():
> Accounts not at all when the page isn't migrated, otherwise
> accounts against the node we migrated towards.
>
> This seems wrong to me; all three sites should have the same
> sementaics, furthermore we should accounts against where the page
> really is, we already know where the task is.
>

Agreed. To allow the scheduler parts to still be evaluated in proper
isolation I moved this patch to much earlier in the series.

--
Mel Gorman
SUSE Labs


\
 
 \ /
  Last update: 2013-07-31 13:41    [W:0.304 / U:16.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site