lkml.org 
[lkml]   [2013]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sched, numa: Use {cpu, pid} to create task groups for shared faults
On Wed, Jul 31, 2013 at 11:45:09AM -0400, Don Morris wrote:
> > +
> > +static void task_numa_free(struct task_struct *p)
> > +{
> > + kfree(p->numa_faults);
> > + if (p->numa_group) {
> > + struct numa_group *grp = p->numa_group;
>
> See below.
>
> > + int i;
> > +
> > + for (i = 0; i < 2*nr_node_ids; i++)
> > + atomic_long_sub(p->numa_faults[i], &grp->faults[i]);
> > +
> > + spin_lock(&p->numa_lock);
> > + spin_lock(&group->lock);
> > + list_del(&p->numa_entry);
> > + spin_unlock(&group->lock);
> > + rcu_assign_pointer(p->numa_group, NULL);
> > + put_numa_group(grp);
>
> So is the local variable group or grp here? Got to be one or the
> other to compile...

Feh, compiling is soooo overrated! :-)

Thanks.


\
 
 \ /
  Last update: 2013-07-31 18:21    [W:0.094 / U:1.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site