lkml.org 
[lkml]   [2013]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 19/19] [INCOMPLETE] ARM: make return_address available for ARM_UNWIND
From
Date
[ I got an error with linux-arm-kernel@list.infradead.org and had to
remove from CC ]

On Fri, 2013-01-25 at 16:26 +0000, Dave Martin wrote:

> However, if the purpose if making return_address() notrace is just to
> prevent infinite recursion, where finite recursion is safe, then it
> feels fixable as described above.
>
> Steven, do you know whether such an approach might be safe?
>

I rewrote the function trace recursion code (see linux-next). The
function tracer wont recurse on itself. If the return_address() is only
used by callbacks and not directly by the mcount(ftrace_caller), then
after the first trace, ftrace wont let recursion of the callback. IOW,
callbacks of ftrace don't need to worry about re-entrancy at the same
context level (but do for different contexts, ie. normal, irq, softirq
and NMI).

(commit edc15cafcbfa3d73f819cae99885a2e35e4cbce5 in linux-next and
friends)

-- Steve




\
 
 \ /
  Last update: 2013-01-25 18:21    [W:0.339 / U:49.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site