| Date | Tue, 29 Jan 2013 23:08:41 +0100 | Subject | Re: [PATCH 12/19] pinctrl: exynos: don't mark probing functions as __init | From | Linus Walleij <> |
| |
On Fri, Jan 25, 2013 at 3:14 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> Functions called from a driver probe() method must not be > marked __init, because they may get called after the > init phase is done, when the device shows up late, or > because of deferred probing. > > Without this patch, building exynos_defconfig results in > multiple warnings like: > > WARNING: drivers/pinctrl/built-in.o(.text+0x51bc): Section mismatch in reference from the function exynos5440_pinctrl_probe() to the function .init.text:exynos5440_gpiolib_register() > The function exynos5440_pinctrl_probe() references > the function __init exynos5440_gpiolib_register(). > This is often because exynos5440_pinctrl_probe lacks a __init > annotation or the annotation of exynos5440_gpiolib_register is wrong. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Tomasz Figa <t.figa@samsung.com> > Cc: Kukjin Kim <kgene.kim@samsung.com>
Applied with Kukjin's ACK, thanks!
Yours, Linus Walleij
|