lkml.org 
[lkml]   [2013]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 09/19] mfd/twl4030: don't warn about uninitialized return code
    Date
    If the twl4030_write_script function gets called with
    a zero length argument, its return value does not
    get set. We know that all scripts have a nonzero
    length, but returning an error in case they ever
    do is probably appropriate.

    Without this patch, building omap2plus_defconfig results in:

    drivers/mfd/twl4030-power.c: In function 'load_twl4030_script':
    drivers/mfd/twl4030-power.c:414:5: error: 'err' may be used uninitialized in this function

    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
    Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
    Cc: Samuel Ortiz <sameo@linux.intel.com>
    Cc: Kevin Hilman <khilman@deeprootsystems.com>
    Cc: "Kristo, Tero" <t-kristo@ti.com>
    ---
    drivers/mfd/twl4030-power.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
    index 4dae241..dd362c1 100644
    --- a/drivers/mfd/twl4030-power.c
    +++ b/drivers/mfd/twl4030-power.c
    @@ -159,7 +159,7 @@ out:
    static int twl4030_write_script(u8 address, struct twl4030_ins *script,
    int len)
    {
    - int err;
    + int err = -EINVAL;

    for (; len; len--, address++, script++) {
    if (len == 1) {
    --
    1.8.0


    \
     
     \ /
      Last update: 2013-01-26 10:01    [W:4.464 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site