| From | Kukjin Kim <> | Subject | RE: [PATCH 12/19] pinctrl: exynos: don't mark probing functions as __init | Date | Fri, 25 Jan 2013 09:51:39 -0800 |
| |
Arnd Bergmann wrote: > > Functions called from a driver probe() method must not be > marked __init, because they may get called after the > init phase is done, when the device shows up late, or > because of deferred probing. > > Without this patch, building exynos_defconfig results in > multiple warnings like: > > WARNING: drivers/pinctrl/built-in.o(.text+0x51bc): Section mismatch in > reference from the function exynos5440_pinctrl_probe() to the > function .init.text:exynos5440_gpiolib_register() > The function exynos5440_pinctrl_probe() references > the function __init exynos5440_gpiolib_register(). > This is often because exynos5440_pinctrl_probe lacks a __init > annotation or the annotation of exynos5440_gpiolib_register is wrong. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Tomasz Figa <t.figa@samsung.com> > Cc: Kukjin Kim <kgene.kim@samsung.com>
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Thanks.
- Kukjin
|