| Date | Tue, 25 Jan 2005 07:17:41 +0100 | From | Andi Kleen <> | Subject | Re: [PATCH] move common compat ioctls to hash |
| |
On Mon, Jan 24, 2005 at 10:26:09PM +0200, Michael S. Tsirkin wrote: > Hi! > The new ioctl code in fs/compat.c can be streamlined a little > using the compat hash instead of an explicit switch statement. > > The attached patch is against 2.6.11-rc2-bk2. > Andi, could you please comment? Does this make sence?
Problem is that when a compat_ioctl handler returns -EINVAL instead of -ENOIOCTLCMD on unknown ioctl it won't check the common ones.
I fear this mistake would be common, that is why I put in the switch.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|