Messages in this thread | | | From | "Luck, Tony" <> | Subject | RE: [PATCH v2 16/16] EDAC/mce_amd: Add support for FRU Text in MCA | Date | Fri, 5 Apr 2024 16:06:36 +0000 |
| |
> diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c > index aa27729f7899..a4d09dda5fae 100644 > --- a/arch/x86/kernel/cpu/mce/core.c > +++ b/arch/x86/kernel/cpu/mce/core.c > @@ -207,6 +207,8 @@ static void __print_mce(struct mce_hw_err *err) > pr_cont("SYND2 %llx ", err->vi.amd.synd2); > if (m->ipid) > pr_cont("IPID %llx ", m->ipid); > + if (err->vi.amd.config)
This is in common code. If other vendors start adding their own stuff to the "vi" union you might incorrectly print this. Add a vendor check before looking at values inside "m->vi".
> + pr_cont("CONFIG %llx ", err->vi.amd.config); > } > > pr_cont("\n");
| |