Messages in this thread | | | Date | Tue, 23 Apr 2024 15:16:46 -0400 | Subject | Re: [PATCH v2 04/16] x86/mce/amd: Look up bank type by IPID | From | Yazen Ghannam <> |
| |
On 4/23/2024 1:06 PM, Borislav Petkov wrote: > On Thu, Apr 04, 2024 at 10:13:47AM -0500, Yazen Ghannam wrote: >> Scalable MCA systems use values within the MCA_IPID register to describe >> a bank's type. Other information is not needed. >> >> Currently, the bank types are cached during boot and this information is >> used during boot and run time. The cached values are per-CPU and >> per-bank. The boot path needs the cached values, but this should be >> removed. The run time path does not need the cached values. >> >> Determine a Scalable MCA bank's type using only the MCA_IPID values. > > Lemme get this straight: You want to switch it all to use this new array > smca_hwid_mcatypes[] to lookup HWIDs? > > If so, where is the patch which removes the _old thing? >
It would be part of a follow up set.
Here's where it would finally be removed after a bunch of refactoring.
https://github.com/AMDESE/linux/commit/291c85ae22277
>> arch/x86/include/asm/mce.h | 4 +- >> arch/x86/kernel/cpu/mce/amd.c | 99 ++++++++++++++++++++++--- >> drivers/edac/amd64_edac.c | 2 +- >> drivers/edac/mce_amd.c | 2 +- >> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +- > > $ ./scripts/get_maintainer.pl -f drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > Alex Deucher <alexander.deucher@amd.com> (supporter:RADEON and AMDGPU DRM DRIVERS,commit_signer:91/89=100%) > "Christian König" <christian.koenig@amd.com> (supporter:RADEON and AMDGPU DRM DRIVERS) > "Pan, Xinhui" <Xinhui.Pan@amd.com> (supporter:RADEON and AMDGPU DRM DRIVERS) > David Airlie <airlied@gmail.com> (maintainer:DRM DRIVERS > ... > > You need to CC folks on changes touching their area... >
Yep, sorry I missed that. The same is true for the wrapper struct patches later in the set. They touch all places with MCE notifiers.
Thanks, Yazen
| |