Messages in this thread | | | Subject | Re: [PATCH 08/17] clk: samsung: gs101: add support for cmu_hsi2 | From | André Draszik <> | Date | Thu, 04 Apr 2024 14:24:37 +0100 |
| |
Hi Pete,
Thanks for this!
I haven't reviewed this, but one immediate comment...
On Thu, 2024-04-04 at 13:25 +0100, Peter Griffin wrote: > [...] > diff --git a/drivers/clk/samsung/clk-gs101.c b/drivers/clk/samsung/clk-gs101.c > index d065e343a85d..b9f84c7d5c22 100644 > --- a/drivers/clk/samsung/clk-gs101.c > +++ b/drivers/clk/samsung/clk-gs101.c > @@ -22,6 +22,7 @@ > #define CLKS_NR_MISC (CLK_GOUT_MISC_XIU_D_MISC_ACLK + 1) > #define CLKS_NR_PERIC0 (CLK_GOUT_PERIC0_SYSREG_PERIC0_PCLK + 1) > #define CLKS_NR_PERIC1 (CLK_GOUT_PERIC1_SYSREG_PERIC1_PCLK + 1) > +#define CLKS_NR_HSI2 (CLK_GOUT_HSI2_XIU_P_HSI2_ACLK + 1)
Can you please keep the #defines alphabetical (hsi before misc).
> > /* ---- CMU_TOP ------------------------------------------------------------- */ > > @@ -3409,6 +3410,560 @@ static const struct samsung_cmu_info peric1_cmu_info __initconst = { > .clk_name = "bus", > }; > > +/* ---- CMU_HSI2 ---------------------------------------------------------- */
and this code block should be earlier in the file
> [..] > static int __init gs101_cmu_probe(struct platform_device *pdev) > @@ -3432,6 +3987,9 @@ static const struct of_device_id gs101_cmu_of_match[] = { > }, { > .compatible = "google,gs101-cmu-peric1", > .data = &peric1_cmu_info, > + }, { > + .compatible = "google,gs101-cmu-hsi2", > + .data = &hsi2_cmu_info, > }, {
and this block should move up
> }, > }; > diff --git a/include/dt-bindings/clock/google,gs101.h b/include/dt-bindings/clock/google,gs101.h > index 3dac3577788a..ac239ce6821b 100644 > --- a/include/dt-bindings/clock/google,gs101.h > +++ b/include/dt-bindings/clock/google,gs101.h > @@ -518,4 +518,67 @@ > #define CLK_GOUT_PERIC1_CLK_PERIC1_USI9_USI_CLK 45 > #define CLK_GOUT_PERIC1_SYSREG_PERIC1_PCLK 46 > > +/* CMU_HSI2 */
and all these defines, too.
Cheers, Andre'
| |