lkml.org 
[lkml]   [2024]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 01/17] dt-bindings: clock: google,gs101-clock: add HSI2 clock management unit
    From
    Date
    Hi Pete,

    On Thu, 2024-04-04 at 13:25 +0100, Peter Griffin wrote:
    > Add dt schema documentation and clock IDs for the High Speed Interface
    > 2 (HSI2) clock management unit. This CMU feeds high speed interfaces
    > such as PCIe and UFS.
    >
    > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
    > ---
    >  .../bindings/clock/google,gs101-clock.yaml    | 30 +++++++++++++++++--
    >  1 file changed, 28 insertions(+), 2 deletions(-)
    >
    > diff --git a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml b/Documentation/devicetree/bindings/clock/google,gs101-
    > clock.yaml
    > index 1d2bcea41c85..a202fd5d1ead 100644
    > --- a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
    > +++ b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
    > @@ -32,14 +32,15 @@ properties:
    >        - google,gs101-cmu-misc
    >        - google,gs101-cmu-peric0
    >        - google,gs101-cmu-peric1
    > +      - google,gs101-cmu-hsi2

    Can you keep this alphabetical and add hsi before misc please.
    >  
    >    clocks:
    >      minItems: 1
    > -    maxItems: 3
    > +    maxItems: 5
    >  
    >    clock-names:
    >      minItems: 1
    > -    maxItems: 3
    > +    maxItems: 5
    >  
    >    "#clock-cells":
    >      const: 1
    > @@ -112,6 +113,31 @@ allOf:
    >              - const: bus
    >              - const: ip
    >  
    > +  - if:
    > +      properties:
    > +        compatible:
    > +          contains:
    > +            enum:
    > +              - google,gs101-cmu-hsi2

    this block should also come before misc please.

    Once done, feel free to add

    Reviewed-by: André Draszik <andre.draszik@linaro.org>


    > +
    > +    then:
    > +      properties:
    > +        clocks:
    > +          items:
    > +            - description: External reference clock (24.576 MHz)
    > +            - description: High Speed Interface bus clock (from CMU_TOP)
    > +            - description: High Speed Interface pcie clock (from CMU_TOP)
    > +            - description: High Speed Interface ufs clock (from CMU_TOP)
    > +            - description: High Speed Interface mmc clock (from CMU_TOP)
    > +
    > +        clock-names:
    > +          items:
    > +            - const: oscclk
    > +            - const: bus
    > +            - const: pcie
    > +            - const: ufs_embd
    > +            - const: mmc_card
    > +
    >  additionalProperties: false
    >  
    >  examples:

    \
     
     \ /
      Last update: 2024-05-27 16:24    [W:5.392 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site