lkml.org 
[lkml]   [2020]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] rtc: i2c/spi: Avoid inclusion of REGMAP support when not needed
Hi Alexandre,

On Mon, Jan 27, 2020 at 11:45 PM Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
> On 12/01/2020 18:13:49+0100, Geert Uytterhoeven wrote:
> > Merely enabling I2C and RTC selects REGMAP_I2C and REGMAP_SPI, even when
> > no driver needs it. While the former can be moduler, the latter cannot,
> > and thus becomes built-in.
> >
> > Fix this by moving the select statements for REGMAP_I2C and REGMAP_SPI
> > from the RTC_I2C_AND_SPI helper to the individual drivers that depend on
> > it.
> >
> > Note that the comment for RTC_I2C_AND_SPI refers to SND_SOC_I2C_AND_SPI
> > for more information, but the latter does not select REGMAP_{I2C,SPI}
> > itself, and defers that to the individual drivers, too.
> >
> > Fixes: 080481f54ef62121 ("rtc: merge ds3232 and ds3234")
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > ---
> > Joe: When merging addresses, scripts/get_maintainer.pl replaces
> > Alexandre's authoritative email address from MAINTAINERS by the
> > obsolete address in the SoB-line of the commit referred to by the
> > Fixes-line.
> >
> > drivers/rtc/Kconfig | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> Applied, thanks.

According to the reports from kbuild test report, some drivers are still
missing some selects, which is exposed by this patch.
But perhaps you have already fixed those in your tree?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2020-01-28 09:34    [W:0.155 / U:3.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site