[lkml]   [2020]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] rtc: i2c/spi: Avoid inclusion of REGMAP support when not needed
On 12/01/2020 18:13:49+0100, Geert Uytterhoeven wrote:
> Merely enabling I2C and RTC selects REGMAP_I2C and REGMAP_SPI, even when
> no driver needs it. While the former can be moduler, the latter cannot,
> and thus becomes built-in.
> Fix this by moving the select statements for REGMAP_I2C and REGMAP_SPI
> from the RTC_I2C_AND_SPI helper to the individual drivers that depend on
> it.
> Note that the comment for RTC_I2C_AND_SPI refers to SND_SOC_I2C_AND_SPI
> for more information, but the latter does not select REGMAP_{I2C,SPI}
> itself, and defers that to the individual drivers, too.
> Fixes: 080481f54ef62121 ("rtc: merge ds3232 and ds3234")
> Signed-off-by: Geert Uytterhoeven <>
> ---
> Joe: When merging addresses, scripts/ replaces
> Alexandre's authoritative email address from MAINTAINERS by the
> obsolete address in the SoB-line of the commit referred to by the
> Fixes-line.
> drivers/rtc/Kconfig | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Applied, thanks.

Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering

 \ /
  Last update: 2020-01-27 23:47    [W:0.073 / U:3.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site