lkml.org 
[lkml]   [2020]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] rtc: i2c/spi: Avoid inclusion of REGMAP support when not needed
Hi Joe,

On Mon, Jan 13, 2020 at 8:41 AM Joe Perches <joe@perches.com> wrote:
> On Mon, 2020-01-13 at 08:25 +0100, Geert Uytterhoeven wrote:
> > On Mon, Jan 13, 2020 at 7:36 AM Joe Perches <joe@perches.com> wrote:
> > > On Sun, 2020-01-12 at 18:13 +0100, Geert Uytterhoeven wrote:
> > > > Merely enabling I2C and RTC selects REGMAP_I2C and REGMAP_SPI, even when
> > > > no driver needs it. While the former can be moduler, the latter cannot,
> > > > and thus becomes built-in.
> > > >
> > > > Fix this by moving the select statements for REGMAP_I2C and REGMAP_SPI
> > > > from the RTC_I2C_AND_SPI helper to the individual drivers that depend on
> > > > it.
> > > >
> > > > Note that the comment for RTC_I2C_AND_SPI refers to SND_SOC_I2C_AND_SPI
> > > > for more information, but the latter does not select REGMAP_{I2C,SPI}
> > > > itself, and defers that to the individual drivers, too.
> > > >
> > > > Fixes: 080481f54ef62121 ("rtc: merge ds3232 and ds3234")
> > > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > > > ---
> > > > Joe: When merging addresses, scripts/get_maintainer.pl replaces
> > > > Alexandre's authoritative email address from MAINTAINERS by the
> > > > obsolete address in the SoB-line of the commit referred to by the
> > > > Fixes-line.
> > >
> > > Hi Geert
> > >
> > > What are you doing to get this changed output?
> >
> > scripts/get_maintainer.pl
> > 0001-rtc-i2c-spi-Avoid-inclusion-of-REGMAP-support-when-n.patch
> >
> > > I get the same get_maintainer address output either way
> > > with only with the 'blamed_fixes:' content added.
> >
> > Thanks, I can confirm it's fixed in next-20200110.
> > With v5.5-rc6, it still gives the old addresss.
>
> Well, OK, get_maintainer is the same but there is a
> different .mailmap in -next

Indeed.

However, I think the precedence should be

MAINTAINERS > .mailmap > SoB in referenced commit

instead of

.mailmap > SoB in referenced commit > MAINTAINERS

Do you agree?
Thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2020-01-13 08:59    [W:0.063 / U:2.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site