lkml.org 
[lkml]   [2020]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] rtc: i2c/spi: Avoid inclusion of REGMAP support when not needed
Hi,

On 28/01/2020 09:33:28+0100, Geert Uytterhoeven wrote:
> Hi Alexandre,
>
> On Mon, Jan 27, 2020 at 11:45 PM Alexandre Belloni
> <alexandre.belloni@bootlin.com> wrote:
> > On 12/01/2020 18:13:49+0100, Geert Uytterhoeven wrote:
> > > Merely enabling I2C and RTC selects REGMAP_I2C and REGMAP_SPI, even when
> > > no driver needs it. While the former can be moduler, the latter cannot,
> > > and thus becomes built-in.
> > >
> > > Fix this by moving the select statements for REGMAP_I2C and REGMAP_SPI
> > > from the RTC_I2C_AND_SPI helper to the individual drivers that depend on
> > > it.
> > >
> > > Note that the comment for RTC_I2C_AND_SPI refers to SND_SOC_I2C_AND_SPI
> > > for more information, but the latter does not select REGMAP_{I2C,SPI}
> > > itself, and defers that to the individual drivers, too.
> > >
> > > Fixes: 080481f54ef62121 ("rtc: merge ds3232 and ds3234")
> > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > > ---
> > > Joe: When merging addresses, scripts/get_maintainer.pl replaces
> > > Alexandre's authoritative email address from MAINTAINERS by the
> > > obsolete address in the SoB-line of the commit referred to by the
> > > Fixes-line.
> > >
> > > drivers/rtc/Kconfig | 8 ++++++--
> > > 1 file changed, 6 insertions(+), 2 deletions(-)
> > >
> > Applied, thanks.
>
> According to the reports from kbuild test report, some drivers are still
> missing some selects, which is exposed by this patch.
> But perhaps you have already fixed those in your tree?
>

I did fix a bunch of those in
https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?h=rtc-next&id=578c2b661e2b1b474ea3571a3c3c6d57bae89e8d

kbuild reported that it successfully built a few configuration with that
patch applied so I'm hoping it is enough.

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

\
 
 \ /
  Last update: 2020-01-28 09:51    [W:0.058 / U:10.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site