Messages in this thread | | | Subject | Re: [PATCH] rtc: i2c/spi: Avoid inclusion of REGMAP support when not needed | From | Joe Perches <> | Date | Sun, 12 Jan 2020 22:36:00 -0800 |
| |
On Sun, 2020-01-12 at 18:13 +0100, Geert Uytterhoeven wrote: > Merely enabling I2C and RTC selects REGMAP_I2C and REGMAP_SPI, even when > no driver needs it. While the former can be moduler, the latter cannot, > and thus becomes built-in. > > Fix this by moving the select statements for REGMAP_I2C and REGMAP_SPI > from the RTC_I2C_AND_SPI helper to the individual drivers that depend on > it. > > Note that the comment for RTC_I2C_AND_SPI refers to SND_SOC_I2C_AND_SPI > for more information, but the latter does not select REGMAP_{I2C,SPI} > itself, and defers that to the individual drivers, too. > > Fixes: 080481f54ef62121 ("rtc: merge ds3232 and ds3234") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > Joe: When merging addresses, scripts/get_maintainer.pl replaces > Alexandre's authoritative email address from MAINTAINERS by the > obsolete address in the SoB-line of the commit referred to by the > Fixes-line.
Hi Geert
What are you doing to get this changed output?
I get the same get_maintainer address output either way with only with the 'blamed_fixes:' content added.
Your email with 'Fixes:' line:
$ ./scripts/get_maintainer.pl ~/geert_1.mbox Alessandro Zummo <a.zummo@towertech.it> (maintainer:REAL TIME CLOCK (RTC) SUBSYSTEM) Alexandre Belloni <alexandre.belloni@bootlin.com> (maintainer:REAL TIME CLOCK (RTC) SUBSYSTEM,blamed_fixes:1/1=100%) Akinobu Mita <akinobu.mita@gmail.com> (blamed_fixes:1/1=100%) linux-rtc@vger.kernel.org (open list:REAL TIME CLOCK (RTC) SUBSYSTEM) linux-kernel@vger.kernel.org (open list)
Your email without 'Fixes:' line:
$ ./scripts/get_maintainer.pl ~/geert_2.mbox Alessandro Zummo <a.zummo@towertech.it> (maintainer:REAL TIME CLOCK (RTC) SUBSYSTEM) Alexandre Belloni <alexandre.belloni@bootlin.com> (maintainer:REAL TIME CLOCK (RTC) SUBSYSTEM) linux-rtc@vger.kernel.org (open list:REAL TIME CLOCK (RTC) SUBSYSTEM) linux-kernel@vger.kernel.org (open list)
| |