| From | Timur Tabi <> | Date | Mon, 11 Nov 2019 23:17:19 -0600 | Subject | Re: [PATCH v4 04/47] soc: fsl: qe: introduce qe_io{read,write}* wrappers |
| |
On Fri, Nov 8, 2019 at 7:03 AM Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote: > > The QUICC engine drivers use the powerpc-specific out_be32() etc. In > order to allow those drivers to build for other architectures, those > must be replaced by iowrite32be(). However, on powerpc, out_be32() is > a simple inline function while iowrite32be() is out-of-line. So in > order not to introduce a performance regression on powerpc when making > the drivers work on other architectures, introduce qe_io* helpers.
Isn't it also true that iowrite32be() assumes a little-endian platform and always does a byte swap?
|