lkml.org 
[lkml]   [2019]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v4 32/47] serial: ucc_uart: use of_property_read_u32() in ucc_uart_probe()
    On Fri, Nov 8, 2019 at 7:03 AM Rasmus Villemoes
    <linux@rasmusvillemoes.dk> wrote:
    >
    > + if (of_property_read_u32(np, "cell-index", &val) &&
    > + of_property_read_u32(np, "device-id", &val)) {

    I know that this is technically correct, but it's obfuscated IMHO.
    'val' is set correctly only when of_property_read_u32(...) is "false",
    which is doubly-weird because of_property_read_u32(...) doesn't
    actually return a boolean.

    I would rather you break this into two if-statements like the original code.

    \
     
     \ /
      Last update: 2019-11-15 05:27    [W:2.570 / U:0.512 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site