lkml.org 
[lkml]   [2019]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 30/47] serial: ucc_uart: factor out soft_uart initialization
From
Date
On 14/11/2019 06.14, Timur Tabi wrote:
> On Fri, Nov 8, 2019 at 7:03 AM Rasmus Villemoes
> <linux@rasmusvillemoes.dk> wrote:
>>
>> - /*
>> - * Determine if we need Soft-UART mode
>> - */
>> if (of_find_property(np, "soft-uart", NULL)) {
>> dev_dbg(&ofdev->dev, "using Soft-UART mode\n");
>> soft_uart = 1;
>> + } else {
>> + return 0;
>> }
>
> How about:
>
> if (!of_find_property(np, "soft-uart", NULL))
> return 0;

of_property_read_bool() if anything. But I didn't want to do that kind
of transformation - just a pure "move this code out and fix the
indentation" with the minor edits needed to hook it back up where it
came from.

> And I think you should be able to get rid of the "soft_uart" variable.

Eh, no, it's used in several other places in the driver. I kind of hope
gcc is smart enough to see that in the !PPC32 case it is a static,
never-assigned-to, never-escapes variable so all the "if (soft_uart)"
branches go away, but that's not really very important.

Rasmus



\
 
 \ /
  Last update: 2019-11-14 10:00    [W:0.072 / U:23.604 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site