lkml.org 
[lkml]   [2017]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 087/138] PM / OPP: Add missing of_node_put(np)
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Tobias Jordan <Tobias.Jordan@elektrobit.com>

    commit 7978db344719dab1e56d05e6fc04aaaddcde0a5e upstream.

    The for_each_available_child_of_node() loop in _of_add_opp_table_v2()
    doesn't drop the reference to "np" on errors. Fix that.

    Fixes: 274659029c9d (PM / OPP: Add support to parse "operating-points-v2" bindings)
    Signed-off-by: Tobias Jordan <Tobias.Jordan@elektrobit.com>
    [ VK: Improved commit log. ]
    Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
    Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


    ---
    drivers/base/power/opp/of.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/base/power/opp/of.c
    +++ b/drivers/base/power/opp/of.c
    @@ -348,6 +348,7 @@ static int _of_add_opp_table_v2(struct d
    if (ret) {
    dev_err(dev, "%s: Failed to add OPP, %d\n", __func__,
    ret);
    + of_node_put(np);
    goto free_table;
    }
    }

    \
     
     \ /
      Last update: 2017-11-28 12:55    [W:2.835 / U:0.428 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site