lkml.org 
[lkml]   [2017]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 040/138] rtlwifi: fix uninitialized rtlhal->last_suspend_sec time
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Arnd Bergmann <arnd@arndb.de>

    commit 3f2a162fab15aee243178b5308bb5d1206fc4043 upstream.

    We set rtlhal->last_suspend_sec to an uninitialized stack variable,
    but unfortunately gcc never warned about this, I only found it
    while working on another patch. I opened a gcc bug for this.

    Presumably the value of rtlhal->last_suspend_sec is not all that
    important, but it does get used, so we probably want the
    patch backported to stable kernels.

    Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82839
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
    +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
    @@ -1378,6 +1378,7 @@ static void _rtl8821ae_get_wakeup_reason

    ppsc->wakeup_reason = 0;

    + do_gettimeofday(&ts);
    rtlhal->last_suspend_sec = ts.tv_sec;

    switch (fw_reason) {

    \
     
     \ /
      Last update: 2017-11-28 12:59    [W:2.468 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site