lkml.org 
[lkml]   [2013]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: net: phy: realtek: add rtl8201f driver
Jongsung Kim <neidhard.kim@lge.com> :
> This patch adds the minimal driver to manage the
> Realtek RTL8201F 10/100Mbps Transceivers.

Your patch contains both "remove unused #define" and "support new hardware"
parts. I am not sure that the former is adequate for submission until
net-next opens.

> diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
[...]
> +static int rtl8201f_config_intr(struct phy_device *phydev)
> +{
> + int err;
> +
> + phy_write(phydev, RTL8201F_PSR, 0x0007); /* select page 7 */

static void rtl8201f_page_select(struct phy_device *phydev, int page) ?

[...]
> @@ -96,16 +141,16 @@ static struct phy_driver rtl8211e_driver = {
>
> static int __init realtek_init(void)
> {
> - int ret;
> -
> - ret = phy_driver_register(&rtl8211b_driver);
> - if (ret < 0)
> + if(phy_driver_register(&rtl8201f_driver) < 0)
^^ -> missing space.

> + return -ENODEV;

Please propagate phy_driver_register error code.

> + if(phy_driver_register(&rtl8211b_driver) < 0)
> return -ENODEV;
> return phy_driver_register(&rtl8211e_driver);

Unbalanced error paths.

> }
>
> static void __exit realtek_exit(void)
> {
> + phy_driver_unregister(&rtl8201f_driver);
> phy_driver_unregister(&rtl8211b_driver);
> phy_driver_unregister(&rtl8211e_driver);

Code duplication.

You may use an array of phy_driver for realtek_{init/exit}

--
Ueimor


\
 
 \ /
  Last update: 2013-05-08 13:21    [W:0.187 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site