Messages in this thread | | | From | "Jongsung Kim" <> | Subject | RE: net: phy: realtek: add rtl8201f driver | Date | Thu, 9 May 2013 11:26:05 +0900 |
| |
Francois Romieu <romieu@fr.zoreil.com> : > Your patch contains both "remove unused #define" and "support new hardware" > parts. I am not sure that the former is adequate for submission until net-next opens.
I see. Sorry for trying touching them even without comment. I won't touch them.
> static void rtl8201f_page_select(struct phy_device *phydev, int page) ?
Okay. Looks better..
>> + if(phy_driver_register(&rtl8201f_driver) < 0) > ^^ -> missing space.
What a shame!
> You may use an array of phy_driver for realtek_{init/exit}
Agreed.
-- Ueimor
| |