Messages in this thread | | | From | "Jongsung Kim" <> | Subject | RE: net: phy: realtek: add rtl8201f driver | Date | Thu, 9 May 2013 11:35:03 +0900 |
| |
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> : > Removal of unused #define's is a matter of a separate cleanup patch...
Sorry. I won't touch them.
>> +static int rtl8201f_ack_interrupt(struct phy_device *phydev) { >> + int err; >> + >> + err = phy_read(phydev, RTL8201F_ISR); > > This could be an initializer and so make the function shorter. >
Agreed. I just thought it's better to make it similar to the rtl821x_ack_interrupt. Then, may I make shorter the rtl821x_ack_interrupt as well as rtl8201f_ack_interrupt?
> > You haven't run this patch thru scripts/checkpatch.pl -- there should be a space between *if* and (. >
Sorry.. what a mistake..
| |