Messages in this thread | | | Date | Fri, 10 May 2013 15:18:28 +0400 | From | Sergei Shtylyov <> | Subject | Re: [PATCH v2 4/4] net: phy: realtek: cleanup code |
| |
Hello.
On 10-05-2013 11:29, Jongsung Kim wrote:
> This patch cleans up the drivers code by:
> - using a consistent way to reference functions > - removing unused macro-definitions > - removing unnecessary new-lines > - making ack_interrupt functions shorter.
> Signed-off-by: Jongsung Kim <neidhard.kim@lge.com> > --- > drivers/net/phy/realtek.c | 29 ++++++++++------------------- > 1 files changed, 10 insertions(+), 19 deletions(-)
> diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c > index 6f0726a..fd09844 100644 > --- a/drivers/net/phy/realtek.c > +++ b/drivers/net/phy/realtek.c [...] > @@ -112,8 +103,8 @@ static struct phy_driver realtek_drv[] = { > .read_status = &genphy_read_status, > .ack_interrupt = &rtl8201f_ack_interrupt, > .config_intr = &rtl8201f_config_intr, > - .suspend = genphy_suspend, > - .resume = genphy_resume, > + .suspend = &genphy_suspend, > + .resume = &genphy_resume,
Contrariwise, you should have dropped & from the other functions. It's completely superfluous.
WBR, Sergei
| |