lkml.org 
[lkml]   [2013]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: net: phy: realtek: add rtl8201f driver
Hello.

On 08-05-2013 14:10, Jongsung Kim wrote:

> This patch adds the minimal driver to manage the
> Realtek RTL8201F 10/100Mbps Transceivers.

> Signed-off-by: Jongsung Kim <neidhard.kim@lge.com>
> ---
> drivers/net/phy/realtek.c | 60 +++++++++++++++++++++++++++++++++++++++-----
> 1 files changed, 53 insertions(+), 7 deletions(-)

> diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
> index 8e7af83..27847ca 100644
> --- a/drivers/net/phy/realtek.c
> +++ b/drivers/net/phy/realtek.c
> @@ -16,9 +16,13 @@
> #include <linux/phy.h>
> #include <linux/module.h>
>
> -#define RTL821x_PHYSR 0x11
> -#define RTL821x_PHYSR_DUPLEX 0x2000
> -#define RTL821x_PHYSR_SPEED 0xc000

Removal of unused #define's is a matter of a separate cleanup patch...

> +/* page 0 register 30 - interrupt indicators and SNR display register */
> +#define RTL8201F_ISR 0x1e
> +/* page 0 register 31 - page select register */
> +#define RTL8201F_PSR 0x1f
> +/* page 7 register 19 - interrupt, WOL enable, and LEDs function register */
> +#define RTL8201F_IER 0x13
> +
> #define RTL821x_INER 0x12
> #define RTL821x_INER_INIT 0x6400
> #define RTL821x_INSR 0x13
> @@ -29,6 +33,15 @@ MODULE_DESCRIPTION("Realtek PHY driver");
> MODULE_AUTHOR("Johnson Leung");
> MODULE_LICENSE("GPL");
>
> +static int rtl8201f_ack_interrupt(struct phy_device *phydev)
> +{
> + int err;
> +
> + err = phy_read(phydev, RTL8201F_ISR);

This could be an initializer and so make the function shorter.

> +
> + return (err < 0) ? err : 0;
> +}
> +
> static int rtl821x_ack_interrupt(struct phy_device *phydev)
> {
> int err;
[...]
> @@ -96,16 +141,16 @@ static struct phy_driver rtl8211e_driver = {
>
> static int __init realtek_init(void)
> {
> - int ret;
> -
> - ret = phy_driver_register(&rtl8211b_driver);
> - if (ret < 0)
> + if(phy_driver_register(&rtl8201f_driver) < 0)
> + return -ENODEV;
> + if(phy_driver_register(&rtl8211b_driver) < 0)

You haven't run this patch thru scripts/checkpatch.pl -- there
should be a space between *if* and (.

WBR, Sergei



\
 
 \ /
  Last update: 2013-05-08 18:21    [W:0.252 / U:3.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site