Messages in this thread | | | Date | Wed, 8 May 2013 18:03:32 +0200 | From | Fabio Baltieri <> | Subject | Re: [PATCH 4/6] ASoC: ux500: Update tx tdm slots configuration |
| |
On Wed, May 08, 2013 at 12:01:49PM +0100, Mark Brown wrote: > On Wed, May 08, 2013 at 09:14:19AM +0200, Fabio Baltieri wrote: > > Update ab8500-codec and mop500_ab8500 tx slot configuration to reflect > > the actual one used by STE. Also update a wrong comment in the process. > > This seems wrong, the individual chip drivers should just be doing > whatever they're being told by the machine driver. Sounds like there's > two fixes needed here - one is to change the TDM API so that the chip > drivers are just implementing configuration supplied by the machine > driver and the other is to change the configuration being done to > whatever is desired.
Ok so, this patch was really just going to slightly align the configuration with the STE driver. I'll drop it and just fix the wrong comment as a trivial patch.
For the reimplementation with channel configuration from machine driver, I actually went through that, but was not able to find the reason why there is a slot offset somewhere (example: I request 0x0001 for first slot on the DAI and that shows up on slot 8 on the codec), so I just updated the hardcoded value. I'll try to get some explanation for that.
Fabio
-- Fabio Baltieri
| |