Messages in this thread | | | Date | Wed, 8 May 2013 13:42:16 +0200 | From | Fabio Baltieri <> | Subject | Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support |
| |
On Wed, May 08, 2013 at 11:51:24AM +0100, Mark Brown wrote: > On Wed, May 08, 2013 at 09:14:18AM +0200, Fabio Baltieri wrote: > > Drop pinctrl default/sleep state switching code, as it was breaking the > > capture interface by putting the I2S pins in hi-z mode regardless of its > > usage status, and not giving any real benefit. > > > > Pinctrl default mode configuration is already managed automatically by a > > specific pinctrl hog. > > I tend to agree with Lee that this looks like a bad approach - there's a > whole bunch of other code in there which I'd guess is probably equally > broken but only the pinctrl code is being removed. Why not just fix it > (or better yet simplify all this stuff)?
Sorry I did not get the subject, are you referring to other broken code in the ux500 driver or to pinctrl and shared pins in generals?
Fabio
-- Fabio Baltieri
| |