Messages in this thread | | | Date | Wed, 8 May 2013 09:47:22 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 1/6] ASoC: ab8500-codec: Add missing ad_to_slot definitions |
| |
On Wed, 08 May 2013, Fabio Baltieri wrote:
> On Wed, May 08, 2013 at 08:53:28AM +0100, Lee Jones wrote: > > I'm sure this is just me, but: > > > > > 0 to 7 corresponds to AD_OUTx slots > > > char * const enum_ad_to_slot_map[] = {"AD_OUT1", 0 > > 1..5 ??? > > > "AD_OUT7", 6 > > > "AD_OUT8", 7 > > I'm a bit confused... the first one was from the diff header, while OUT7 and > OUT8 are context lines, so 1 to 5 are already there but not shown in the > patch. The final array is like: > > static const char * const enum_ad_to_slot_map[] = {"AD_OUT1", > "AD_OUT2", > "AD_OUT3", > "AD_OUT4", > "AD_OUT5", > "AD_OUT6", > "AD_OUT7", > "AD_OUT8", > "zeroes", > "zeroes", > "zeroes", > "zeroes", > "tristate", > "tristate", > "tristate", > "tristate"}; > > Is it ok?
Yes, I see that now.
Acked-by: Lee Jones <lee.jones@linaro.org>
> > > 8 to 11 corresponds to zero output > > > "zeroes", 8 > > > + "zeroes", 9 > > > + "zeroes", 10 > > > + "zeroes", 11 > > > 12 to 15 sets the output in tristate mode > > > + "tristate", 12 > > > + "tristate", 13 > > > + "tristate", 14 > > > "tristate"}; 15 > > > > >
-- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |