Messages in this thread | | | Date | Wed, 8 May 2013 13:30:36 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 6/6] ASoC: ux500: Use the first two AD slots for capture |
| |
On Wed, May 08, 2013 at 12:12:53PM +0100, Lee Jones wrote: > On Wed, 08 May 2013, Mark Brown wrote:
> > If these are routing specific analogue inputs to specific timeslots then > > this is routing that should be being exposed to DAPM as muxes, not hard > > coded in the middle of TDM slot configuration (which is both obscure and > > not what the TDM API is there for). The TDM API should be purely about > > placing the timeslots for the audio interface on the bus.
> Again, I think this patch is a valid bugfix. If the driver requires > refactoring, it should be done by someone else. That's not the purpose > of Fabio's role.
It's a configuraiton change not a bug fix as far as I can see. [unhandled content-type:application/pgp-signature] | |