lkml.org 
[lkml]   [2012]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 19/26] [SCSI] qla2xxx: Remove redundant NULL check before release_firmware() call.


On Mon, 9 Apr 2012, Jesper Juhl wrote:

> release_firmware() checks for NULL pointers internally so checking
> before calling it is redundant.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
> drivers/scsi/qla2xxx/qla_os.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index a2f9992..91b6fe6 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -4106,8 +4106,7 @@ qla2x00_release_firmware(void)
>
> mutex_lock(&qla_fw_lock);
> for (idx = 0; idx < FW_BLOBS; idx++)
> - if (qla_fw_blobs[idx].fw)
> - release_firmware(qla_fw_blobs[idx].fw);
> + release_firmware(qla_fw_blobs[idx].fw);
> mutex_unlock(&qla_fw_lock);
> }
>
>

Acked-by: Chad Dupuis <chad.dupuis@qlogic.com>

This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.



\
 
 \ /
  Last update: 2012-04-10 14:25    [W:0.138 / U:1.432 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site