lkml.org 
[lkml]   [2012]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 02/26] radeon_cp: Remove unneeded tests for NULL before calling release_firmware()
    release_firmware() does its own tests for NULL pointers so there's no
    need to explicitly test before calling it.

    Signed-off-by: Jesper Juhl <jj@chaosbits.net>
    ---
    drivers/gpu/drm/radeon/radeon_cp.c | 12 ++++--------
    1 file changed, 4 insertions(+), 8 deletions(-)

    diff --git a/drivers/gpu/drm/radeon/radeon_cp.c b/drivers/gpu/drm/radeon/radeon_cp.c
    index 0ebb7d4..ef67e18 100644
    --- a/drivers/gpu/drm/radeon/radeon_cp.c
    +++ b/drivers/gpu/drm/radeon/radeon_cp.c
    @@ -1827,14 +1827,10 @@ void radeon_do_release(struct drm_device * dev)
    r600_do_cleanup_cp(dev);
    else
    radeon_do_cleanup_cp(dev);
    - if (dev_priv->me_fw) {
    - release_firmware(dev_priv->me_fw);
    - dev_priv->me_fw = NULL;
    - }
    - if (dev_priv->pfp_fw) {
    - release_firmware(dev_priv->pfp_fw);
    - dev_priv->pfp_fw = NULL;
    - }
    + release_firmware(dev_priv->me_fw);
    + dev_priv->me_fw = NULL;
    + release_firmware(dev_priv->pfp_fw);
    + dev_priv->pfp_fw = NULL;
    }
    }

    --
    1.7.10

    --
    Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
    Don't top-post http://www.catb.org/jargon/html/T/top-post.html
    Plain text mails only, please.



    \
     
     \ /
      Last update: 2012-04-09 22:53    [W:0.021 / U:153.040 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site