lkml.org 
[lkml]   [2012]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 12/26] ipw2200: remove a redundant NULL check before calling release_firmware()
    The release_firmware() function does its own NULL test, so testing
    before calling it is rather redundant.

    Signed-off-by: Jesper Juhl <jj@chaosbits.net>
    ---
    drivers/net/wireless/ipw2x00/ipw2200.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/net/wireless/ipw2x00/ipw2200.c b/drivers/net/wireless/ipw2x00/ipw2200.c
    index 2b02257..77c5d2f 100644
    --- a/drivers/net/wireless/ipw2x00/ipw2200.c
    +++ b/drivers/net/wireless/ipw2x00/ipw2200.c
    @@ -3657,8 +3657,7 @@ static int ipw_load(struct ipw_priv *priv)
    priv->rxq = NULL;
    }
    ipw_tx_queue_free(priv);
    - if (raw)
    - release_firmware(raw);
    + release_firmware(raw);
    #ifdef CONFIG_PM
    fw_loaded = 0;
    raw = NULL;
    --
    1.7.10

    --
    Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
    Don't top-post http://www.catb.org/jargon/html/T/top-post.html
    Plain text mails only, please.



    \
     
     \ /
      Last update: 2012-04-09 22:53    [W:0.019 / U:0.460 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site