lkml.org 
[lkml]   [2012]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 21/26] staging: vt6656: Don't needlessly test for NULL before release_firmware()
    Checking for a NULL pointer before calling release_firmware() is
    redundant since the function does that check itself.

    Signed-off-by: Jesper Juhl <jj@chaosbits.net>
    ---
    drivers/staging/vt6656/main_usb.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
    index 763e028..ee5261a 100644
    --- a/drivers/staging/vt6656/main_usb.c
    +++ b/drivers/staging/vt6656/main_usb.c
    @@ -1257,9 +1257,7 @@ static void __devexit vt6656_disconnect(struct usb_interface *intf)
    }

    device_release_WPADEV(device);
    -
    - if (device->firmware)
    - release_firmware(device->firmware);
    + release_firmware(device->firmware);

    usb_set_intfdata(intf, NULL);
    usb_put_dev(interface_to_usbdev(intf));
    --
    1.7.10

    --
    Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
    Don't top-post http://www.catb.org/jargon/html/T/top-post.html
    Plain text mails only, please.



    \
     
     \ /
      Last update: 2012-04-09 22:55    [W:0.020 / U:59.896 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site