lkml.org 
[lkml]   [2012]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRE: [PATCH 14/26] wireless, mwifiex: drop redundant NULL test before call to release_firmware()
    Hi Jesper,

    Thanks for the patch.

    > Since release_firmware() does its own test for NULL it is redundant to
    > do so before calling it.
    >
    > Signed-off-by: Jesper Juhl <jj@chaosbits.net>

    Acked-by: Bing Zhao <bzhao@marvell.com>

    Thanks,
    Bing

    > ---
    > drivers/net/wireless/mwifiex/main.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/drivers/net/wireless/mwifiex/main.c b/drivers/net/wireless/mwifiex/main.c
    > index 9d1b3ca..2ee6162 100644
    > --- a/drivers/net/wireless/mwifiex/main.c
    > +++ b/drivers/net/wireless/mwifiex/main.c
    > @@ -342,8 +342,7 @@ static int mwifiex_init_hw_fw(struct mwifiex_adapter *adapter)
    > ret = 0;
    >
    > done:
    > - if (adapter->firmware)
    > - release_firmware(adapter->firmware);
    > + release_firmware(adapter->firmware);
    > if (ret)
    > ret = -1;
    > return ret;
    > --
    > 1.7.10
    >
    >
    > --
    > Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
    > Don't top-post http://www.catb.org/jargon/html/T/top-post.html
    > Plain text mails only, please.



    \
     
     \ /
      Last update: 2012-04-09 23:05    [W:0.022 / U:122.468 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site