lkml.org 
[lkml]   [2011]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 34/41] xtensa: No need to reset handler if SA_ONESHOT
    Date
    From: Matt Fleming <matt.fleming@intel.com>

    get_signal_to_deliver() already resets the signal handler if
    SA_ONESHOT is set in ka->sa.sa_flags, there's no need to do it again
    in handle_signal(). Furthermore, because we were modifying
    ka->sa.sa_handler without holding ->sighand->siglock there's the
    potential we can race with another thread if it modifies the signal
    handlers.

    Cc: Oleg Nesterov <oleg@redhat.com>
    Cc: Chris Zankel <chris@zankel.net>
    Signed-off-by: Matt Fleming <matt.fleming@intel.com>
    ---
    arch/xtensa/kernel/signal.c | 3 ---
    1 files changed, 0 insertions(+), 3 deletions(-)

    diff --git a/arch/xtensa/kernel/signal.c b/arch/xtensa/kernel/signal.c
    index 4f53770..24655e3 100644
    --- a/arch/xtensa/kernel/signal.c
    +++ b/arch/xtensa/kernel/signal.c
    @@ -536,9 +536,6 @@ int do_signal(struct pt_regs *regs, sigset_t *oldset)
    /* Set up the stack frame */
    setup_frame(signr, &ka, &info, oldset, regs);

    - if (ka.sa.sa_flags & SA_ONESHOT)
    - ka.sa.sa_handler = SIG_DFL;
    -
    spin_lock_irq(&current->sighand->siglock);
    sigorsets(&current->blocked, &current->blocked, &ka.sa.sa_mask);
    if (!(ka.sa.sa_flags & SA_NODEFER))
    --
    1.7.4.4


    \
     
     \ /
      Last update: 2011-08-11 16:01    [W:0.025 / U:62.296 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site