lkml.org 
[lkml]   [2011]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 19/41] OpenRISC: No need to reset handler if SA_ONESHOT
    On 08/11, Matt Fleming wrote:
    >
    > get_signal_to_deliver() already resets the signal handler if
    > SA_ONESHOT is set in ka->sa.sa_flags,

    Yes.

    > there's no need to do it again
    > in handle_signal().

    Again, this code in fact does nothing, it plays with the copy.

    > Furthermore, because we were modifying
    > ka->sa.sa_handler without holding ->sighand->siglock there's the
    > potential we can race with another thread if it modifies the signal
    > handlers.

    and thus this is not true.



    Afaics, the changelog should be fixed but the patch is fine ;)

    Oleg.



    \
     
     \ /
      Last update: 2011-08-16 18:59    [W:0.020 / U:28.952 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site